[WIP] Drop v4 to reduce size & refactor v5 to slim it down further. #1490
Conversation
- Created package.json for vsts-developer-tools.common-authv5 with dependencies on azure-pipelines-task-lib and azure-pipelines-tasks-azure-arm-rest. - Added tsconfig.json to configure TypeScript compilation for CommonAuth.ts.
|
@copilot don't forget to agg commonauth to the dependabot config |
|
@jessehouwing I've opened a new pull request, #1510, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@copilot This pull request currently doesn't build on the hosted windows agent: npm error code EJSONPARSE |
jessehouwing
changed the title
There was a problem hiding this comment.
Pull Request Overview
This pull request removes legacy v4 build task support from the Azure DevOps extension tasks repository, refactors authentication logic into a dedicated shared package, and streamlines the build configuration to focus exclusively on v5 tasks.
Key changes:
- Extracted authentication helpers into a new
Common-Auth/v5shared package - Removed all v4 task implementations and configuration files
- Updated build scripts and dependency management to target only v5 tasks
Reviewed Changes
Copilot reviewed 70 out of 99 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
BuildTasks/Common-Auth/v5/* |
New shared authentication package containing marketplace endpoint and tfx CLI argument helpers |
BuildTasks/Common/v5/Common.ts |
Removed authentication functions (moved to Common-Auth) and replaced fs-extra with native fs/promises |
BuildTasks/*/v4/* |
Deleted all v4 task implementations, configurations, and package files |
BuildTasks/*/v5/*.ts |
Updated to import authentication functions from new Common-Auth package |
package.json |
Removed v4 compilation and linting scripts; cleaned up deprecated type dependencies |
.github/dependabot.yml |
Removed v4 task directories from automated dependency updates |
test-*.cmd |
Updated test scripts to reference v5 task paths only |
azure-pipelines.yml |
Removed v4 references from build cleanup steps |
Files not reviewed (15)
- BuildTasks/Common-Auth/v5/package-lock.json: Language not supported
- BuildTasks/Common/v4/package-lock.json: Language not supported
- BuildTasks/Common/v5/package-lock.json: Language not supported
- BuildTasks/ExtensionVersion/v4/package-lock.json: Language not supported
- BuildTasks/InstallExtension/v4/package-lock.json: Language not supported
- BuildTasks/IsValidExtensionAgent/v4/package-lock.json: Language not supported
- BuildTasks/PackageExtension/v4/package-lock.json: Language not supported
- BuildTasks/PackageExtension/v5/package-lock.json: Language not supported
- BuildTasks/PublishExtension/v4/package-lock.json: Language not supported
- BuildTasks/PublishExtension/v5/package-lock.json: Language not supported
- BuildTasks/PublishVSExtension/v4/package-lock.json: Language not supported
- BuildTasks/ShareExtension/v4/package-lock.json: Language not supported
- BuildTasks/TfxInstaller/v4/package-lock.json: Language not supported
- BuildTasks/TfxInstaller/v5/package-lock.json: Language not supported
- BuildTasks/UnpublishExtension/v4/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- tmp - fs-extra - @types/tmp
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This pull request removes support for the legacy v4 build tasks from the repository. The changes focus on cleaning up configuration files and source code related to v4, including the removal of package management, build configuration, and implementation files.
tension version build task has been deleted.
This pull request introduces a new shared authentication helper package for v5 tasks, updates automation to focus on v5 task maintenance, and removes legacy v4 task files. The main goal is to centralize and modernize authentication logic for Azure DevOps extension tasks, streamline dependency updates, and clean up obsolete v4 code.
Key changes:
New Shared Authentication Utilities
BuildTasks/Common-Auth/v5package containingCommonAuth.ts, which provides reusable authentication helpers for extension tasks, including functions to retrieve endpoint details and set uptfxCLI arguments for various Azure DevOps connection types. (BuildTasks/Common-Auth/v5/CommonAuth.ts,BuildTasks/Common-Auth/v5/package.json,BuildTasks/Common-Auth/v5/tsconfig.json) [1] [2] [3]Automation and Dependency Update Focus
.github/dependabot.ymlto remove all v4 task directories from automated dependency updates and instead add v5 task directories (including the newCommon-Auth/v5), ensuring future maintenance targets only supported code. [1] [2]Documentation Improvements
.github/copilot-instructions.mdto help contributors understand the architecture, workflows, conventions, and extension task patterns in the repository.Legacy v4 Task Cleanup
BuildTasks/Common/v4/package.json,package-lock.json, andtsconfig.jsonfiles, fully deprecating the v4 Common utilities from the repository. [1] [2] [3]